Skip to content

feat(zsh): add context argument completion#3130

Merged
thaJeztah merged 1 commit into
docker:masterfrom
acouvreur:master
Oct 13, 2022
Merged

feat(zsh): add context argument completion#3130
thaJeztah merged 1 commit into
docker:masterfrom
acouvreur:master

Conversation

@acouvreur

@acouvreur acouvreur commented Jun 10, 2021

Copy link
Copy Markdown
Contributor

- What I did
Add a -c --context docker option completion, resolves -c and --context with the description "Execute the command in a docker context".
And resolves available contexts docker -c=<tab>
image

It also adds the context to the docker_options so the completion is depending on the given context.

- How I did it
This use the same function to list contexts previously added and use of docker_options variable

- How to verify it
Type docker --<tab> should add a --context option
Then type docker --context <tab> should give you the list of contexts available

Have a distant context and try to inspect a resource on it docker -c my-context inspect <TAB> should list you the resources of the given context.
- Description for the changelog
add docker --context argument completion

- A picture of a cute animal (not mandatory but encouraged)
image

@codecov-commenter

codecov-commenter commented Jun 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3130 (79638e6) into master (2ebf5d9) will increase coverage by 3.55%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
+ Coverage   57.09%   60.65%   +3.55%     
==========================================
  Files         299      308       +9     
  Lines       18731    29012   +10281     
==========================================
+ Hits        10695    17598    +6903     
- Misses       7166    10393    +3227     
- Partials      870     1021     +151     

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: acouvreur <alexiscouvreur.pro@gmail.com>
@acouvreur

Copy link
Copy Markdown
Contributor Author

Any update on merge @thaJeztah ? 😄

@acouvreur acouvreur changed the title feat(docker): add context argument completion feat(zsh): add context argument completion Sep 6, 2021
@thaJeztah thaJeztah added this to the 22.06.0 milestone Oct 13, 2022
@thaJeztah

Copy link
Copy Markdown
Member

I guess this one dropped off my list; let me close/reopen to get a fresh run of CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants