Skip to content

docs/daemon: replace deprecated '-g' option for '--data-root' - #3405

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:update_daemon_docs
Jan 13, 2022
Merged

docs/daemon: replace deprecated '-g' option for '--data-root'#3405
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:update_daemon_docs

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

addresses docker/docs#14056

@thaJeztah thaJeztah added this to the 21.xx milestone Jan 11, 2022
@thaJeztah thaJeztah changed the title docs/daemon: replace deprecated '-g' option for '--storage-driver' docs/daemon: replace deprecated '-g' option for '--data-root' Jan 11, 2022

@cpuguy83 cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83

Copy link
Copy Markdown
Collaborator

CI validation didn't like something.

@thaJeztah

Copy link
Copy Markdown
Member Author

oooh, looks like we're somehow hitting the git:// brownout; does vndr default to using git:// protocol?

2022/01/11 11:24:19 Starting whole vndr cycle because no package specified
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

CI is green now, but we should probably look at vndr for the 20.10 branches at least

@thaJeztah
thaJeztah merged commit 6e2838e into docker:master Jan 13, 2022
@thaJeztah
thaJeztah deleted the update_daemon_docs branch January 13, 2022 15:02
@elfranne

Copy link
Copy Markdown

Thanks !

@thaJeztah

Copy link
Copy Markdown
Member Author

yw! This won't be published yet until it's cherry-picked into the 20.10 release branch, but I'll likely do a round of documentation cherry-picks later this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants