Skip to content

[20.10] vendor.conf: golang.org/x/crypto v0.1.0 (Fix ssh: parse error in message type 27 with OpenSSH >= 8.9) - #3862

Merged
thaJeztah merged 1 commit into
docker:20.10from
AkihiroSuda:x-crypto-v0.2.0-docker-20.10
Nov 16, 2022
Merged

[20.10] vendor.conf: golang.org/x/crypto v0.1.0 (Fix ssh: parse error in message type 27 with OpenSSH >= 8.9)#3862
thaJeztah merged 1 commit into
docker:20.10from
AkihiroSuda:x-crypto-v0.2.0-docker-20.10

Conversation

@AkihiroSuda

@AkihiroSuda AkihiroSuda commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

- What I did
Fix ssh: parse error in message type 27 with OpenSSH >= 8.9

- How I did it

Bumped up golang.org/x/crypto to include golang/crypto@bd7e27e

- How to verify it

Run docker build --ssh default with DOCKER_BUILDKIT=1, and make sure no ssh: parse error in message type 27 error occurs

- Description for the changelog

Fix ssh: parse error in message type 27 with OpenSSH >= 8.9

- A picture of a cute animal (not mandatory but encouraged)
🐧

@AkihiroSuda AkihiroSuda changed the title vendor.conf: golang.org/x/crypto v0.2.0 (Fix ssh: parse error in message type 27 with OpenSSH >= 8.9) [20.10] vendor.conf: golang.org/x/crypto v0.2.0 (Fix ssh: parse error in message type 27 with OpenSSH >= 8.9) Nov 15, 2022
@codecov-commenter

codecov-commenter commented Nov 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3862 (2d4e433) into 20.10 (e814bd0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            20.10    #3862   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         299      299           
  Lines       21457    21457           
=======================================
  Hits        12569    12569           
  Misses       7970     7970           
  Partials      918      918           

@thaJeztah

Copy link
Copy Markdown
Member

Given that golang/crypto@bd7e27e is also part of v0.1.0, should we use that tag? (To prevent some churn; users that use this repository as dependency and are using go modules may otherwise be force to also update most golang.org/x/... packages to v0.2.0 or up.

@AkihiroSuda
AkihiroSuda force-pushed the x-crypto-v0.2.0-docker-20.10 branch from fff32de to defa38a Compare November 15, 2022 22:48
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title [20.10] vendor.conf: golang.org/x/crypto v0.2.0 (Fix ssh: parse error in message type 27 with OpenSSH >= 8.9) [20.10] vendor.conf: golang.org/x/crypto v0.1.0 (Fix ssh: parse error in message type 27 with OpenSSH >= 8.9) Nov 16, 2022
@AkihiroSuda
AkihiroSuda force-pushed the x-crypto-v0.2.0-docker-20.10 branch from defa38a to 2d4e433 Compare November 16, 2022 10:08

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 20.10.22 milestone Nov 16, 2022
@thaJeztah
thaJeztah merged commit a60bf81 into docker:20.10 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants