vendor: github.com/docker/docker v26.0.0-rc1 - #4906
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4906 +/- ##
=======================================
Coverage 61.23% 61.24%
=======================================
Files 287 287
Lines 20090 20090
=======================================
+ Hits 12302 12304 +2
+ Misses 6894 6893 -1
+ Partials 894 893 -1 |
thaJeztah
approved these changes
Mar 1, 2024
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
changes LGTM
technically, the commits should probably be squashed, so that the local changes needed go hand-in-hand with the vendor changes that require it.
Let me know if you want to do the squashing (also happy to push to your branch)
full diff: moby/moby@c70d790...v26.0.0-rc1 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> test: update fixtures Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
force-pushed
the
benehiko/v26.0.0-rc1
branch
from
March 1, 2024 17:24
ce22418 to
5e80232
Compare
Member
Author
|
Should the commit message also be sanitized? I kept the previous commit messages when squashing |
thaJeztah
approved these changes
Mar 1, 2024
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
commit message looks fine for this one, no need to over complicate things for this.
Thanks!!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: moby/moby@c70d790...v26.0.0-rc1
Signed-off-by: Alano Terblanche 18033717+Benehiko@users.noreply.github.com