docs: use important callout for buildkit vs legacy builder #5469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5469 +/- ##
=======================================
Coverage 59.74% 59.74%
=======================================
Files 345 345
Lines 23431 23431
=======================================
Hits 13999 13999
Misses 8458 8458
Partials 974 974 |
laurazard
approved these changes
Sep 23, 2024
thaJeztah
approved these changes
Oct 4, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
still considering we should unify these and (where really needed) call out things that are supported / not supported.
We originally had the reverse; the CLI would define options only supported with BuildKit enabled, and those had additional metadata (but those were removed when the build code was removed and moved to buildx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
[!IMPORTANT]for the legacy builder callout