Skip to content

[27.x backport] use important callout for buildkit vs legacy builder #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 1 commit into from
Oct 4, 2024
Merged

[27.x backport] use important callout for buildkit vs legacy builder #5470

thaJeztah merged 1 commit into from
Oct 4, 2024

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Sep 23, 2024

@dvdksn
docs: use important callout for buildkit vs legacy builder
23cea90 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
(cherry picked from commit 8a3d838)
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested review from a team and thaJeztah as code owners September 23, 2024 11:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.78%. Comparing base (ce12230) to head (23cea90).
Report is 10 commits behind head on 27.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##             27.x    #5470      +/-   ##
==========================================
+ Coverage   59.39%   59.78%   +0.39%     
==========================================
  Files         342      345       +3     
  Lines       23434    23442       +8     
==========================================
+ Hits        13918    14015      +97     
+ Misses       8540     8453      -87     
+ Partials      976      974       -2

@dvdksn dvdksn self-assigned this Sep 23, 2024
@thaJeztah thaJeztah added this to the 27.4.0 milestone Oct 4, 2024
thaJeztah
thaJeztah approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit fa0bb9f into docker:27.x Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@laurazard laurazard laurazard approved these changes

Assignees

@dvdksn dvdksn

Labels

kind/docs

Projects

None yet

Milestone

27.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dvdksn @codecov-commenter @thaJeztah @laurazard