opts: add tests for weight/throttle device opts validators#7113
Merged
thaJeztah merged 1 commit intoJul 25, 2026
Conversation
opts/weightdevice.go and opts/throttledevice.go had no tests, unlike the sibling opts. Add table-driven coverage for ValidateWeightDevice, ValidateThrottleBpsDevice, ValidateThrottleIOpsDevice and the Set/GetList paths, including boundary (weight 0/10/1000/overflow) and error cases. Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
nikolauspschuetz
force-pushed
the
test-device-opts-validators
branch
from
July 20, 2026 20:47
ff077f2 to
8f3477f
Compare
nikolauspschuetz
marked this pull request as ready for review
July 20, 2026 22:19
Member
|
Thx! Changes reminds me that I still want to look at removing some of the validation from the CLI itself, because it's very specific; Ultimately those checks belong on the API / daemon-side, and the CLI would be only responsible for parsing it into the right types (at most see if the path is well-formed), But I still need to double check that the API produces a useful error, and not some obscure one 😓 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opts/weightdevice.goandopts/throttledevice.gohad no tests, unlike the other opts in the package. This adds table-driven coverage forValidateWeightDevice,ValidateThrottleBpsDevice,ValidateThrottleIOpsDevice, and theSet/GetListpaths — boundaries (weight 0/10/1000, uint16 overflow), rate parsing (units, integer-only iops), and the format/error cases.Test-only, no behavior change. Part of #201.