vendor: github.com/moby/go-archive v0.2.1#7119
Merged
Merged
Conversation
full diff: moby/go-archive@v0.2.0...v0.2.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR vendors github.com/moby/go-archive v0.2.0 → v0.2.1. The changes are all correctness improvements:
- Whiteout guard fix: The PR moves the non-empty file check to before
WriteHeader(old code wrote the header first, then returned an error — new code validates first). This is a genuine bug fix. - Hardlink tracking:
SeenFiles[inode]now storeshdr.Name(the archive-relative name) instead ofname(the raw on-disk path), which is more correct for archive consumers. - Modern Go idioms:
strings.SplitSeq(Go 1.24+),maps.Copy, range-over-integer — all safe because docker/cli already requires Go 1.25.0. - Device number validation: Bounds-checks
Devmajor/Devminorbeforeunix.Mkdevto prevent silent integer truncation from crafted tar archives. - Error propagation:
getInodeFromStatnow returns an error on unexpected stat types instead of silently returning inode 0. - Nil-safety:
Unpacknow guards against nilTarOptions(previously could panic viaCopyFileWithTarpath).
No issues introduced by this PR. All hypotheses were investigated and dismissed — the changes are improvements, not regressions.
vvoland
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: moby/go-archive@v0.2.0...v0.2.1
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)