cmd: report unknown command before unknown flag - #7291
Open
locker95 wants to merge 2 commits into
Open
Conversation
`docker iamges --filter` was coming back as unknown flag because the root command kept parsing flags after the first token. Stop at the first non-flag so this matches `docker iamges` and says the command is unknown. Fixes docker#4550 Signed-off-by: Dean Chen <862469039@qq.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SetInterspersed(false) made `docker nonexistent --help` fail instead of printing the root help. Rewrite unknown-flag errors only when the first leftover arg isn't a subcommand. Fixes docker#4550 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker iamges --filterwas coming back asunknown flag: --filterbecause the root command kept parsing flags after the first token.stop at the first non-flag so this matches
docker iamgesand says the command is unknown.Fixes #4550