Skip to content

enhanced dockerfile#183

Merged
rumpl merged 8 commits intodocker:mainfrom
crazy-max:improve-dockerfile
Sep 15, 2025
Merged

enhanced dockerfile#183
rumpl merged 8 commits intodocker:mainfrom
crazy-max:improve-dockerfile

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Sep 12, 2025

See individual commits

As follow-up will add a bake definition.

@crazy-max crazy-max force-pushed the improve-dockerfile branch 2 times, most recently from cfdc311 to 2290b80 Compare September 12, 2025 13:58
@jeanlaurent
Copy link
Copy Markdown
Member

Hey @crazy-max let's try to close PR as fast as we can, can you split it between enhancements and zig support ?

@crazy-max
Copy link
Copy Markdown
Member Author

Hey @crazy-max let's try to close PR as fast as we can, can you split it between enhancements and zig support ?

@jeanlaurent We discussed offline with @rumpl about it and we could get rid of CGO if we switch to https://pkg.go.dev/modernc.org/sqlite?utm_source=godoc. Then zig or osxcross would not be needed.

@crazy-max crazy-max force-pushed the improve-dockerfile branch 5 times, most recently from 2ab269f to 7220f5c Compare September 15, 2025 12:54
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
… in heredocs

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review September 15, 2025 13:05
@crazy-max crazy-max requested a review from a team as a code owner September 15, 2025 13:05
Copy link
Copy Markdown
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 thanks

@rumpl rumpl merged commit d92e424 into docker:main Sep 15, 2025
5 checks passed
@crazy-max crazy-max deleted the improve-dockerfile branch September 15, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants