switch to modernc.org/sqlite#192
Merged
rumpl merged 2 commits intodocker:mainfrom Sep 15, 2025
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
modernc-sqlite
branch
from
36215a2 to
16a4cfb
Compare
crazy-max
commented
Sep 15, 2025
|
|
||
| - name: Check licenses | ||
| run: go-licenses check . --allowed_licenses=Apache-2.0,MIT,BSD-3-Clause,BSD-2-Clause | ||
| run: go-licenses check . --allowed_licenses=Apache-2.0,MIT,BSD-3-Clause,BSD-2-Clause --ignore modernc.org/mathutil |
Member
Author
There was a problem hiding this comment.
Needs to ignore license for modernc.org/mathutil that doesn't seem detected by go-licenses: https://github.com/docker/cagent/actions/runs/17728911546/job/50375602792#step:5:20
E0915 09:46:48.013542 4846 library.go:122] Failed to find license for modernc.org/mathutil: cannot find a known open source license for "/home/runner/go/pkg/mod/modernc.org/mathutil@v1.7.1" whose name matches regexp ^(?i)((UN)?LICEN(S|C)E|COPYING|README|NOTICE).*$ and locates up until "/home/runner/go/pkg/mod/modernc.org/mathutil@v1.7.1"
But has a BSD 3-Clause license: https://gitlab.com/cznic/mathutil/-/blob/master/LICENSE
Merged
dgageot
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #183 (comment)
Switch to https://pkg.go.dev/modernc.org/sqlite so we don't need CGO anymore.