Skip to content

fix(toolinstall): soft-fail auto-detect installs#2386

Merged
dgageot merged 1 commit intodocker:mainfrom
pandego:fix/2384-aqua-registry-url
Apr 12, 2026
Merged

fix(toolinstall): soft-fail auto-detect installs#2386
dgageot merged 1 commit intodocker:mainfrom
pandego:fix/2384-aqua-registry-url

Conversation

@pandego
Copy link
Copy Markdown
Contributor

@pandego pandego commented Apr 12, 2026

Fixes #2384

Summary

  • stop treating auto-detected tool install failures as fatal during tool loading
  • keep explicit version: installs strict, so pinned package/version mistakes still surface immediately
  • add focused regression coverage for the new fallback behavior

Testing

  • docker run --rm -v "$PWD":/src -w /src golang:1.26 sh -lc '/usr/local/go/bin/gofmt -w pkg/toolinstall/resolver.go pkg/toolinstall/resolver_test.go && /usr/local/go/bin/go test ./pkg/toolinstall -run "TestEnsureCommand_(AutoDetectFailureFallsBackToOriginalCommand|ExplicitVersionFailureStillErrors|DisabledGlobally|DisabledGlobally_CaseInsensitive|DisabledPerToolset|FoundInBinDir|FoundInPath|NonExecutableInBinDirFallsBackToOriginalCommand)|TestResolve_(FoundInPath|FoundInBinDir|NotFoundAnywhere|InvalidAquaRef)|TestParseAquaRef|TestExtractVersionPrefix" -count=1'

Signed-off-by: pandego <7780875+pandego@users.noreply.github.com>
@pandego pandego requested a review from a team as a code owner April 12, 2026 11:25
@dgageot dgageot merged commit f96edc1 into docker:main Apr 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-Installing LSP Tools fails (404 when querying the aqua registry)

2 participants