feat: add --app-name flag and fix macOS test symlink issue#2914
Merged
Conversation
t.TempDir() returns /var/folders/... on macOS, which is a symlink to /private/var/folders/.... git rev-parse --show-toplevel resolves the symlink, so test assertions comparing the temp dir to repo paths failed. Resolve the symlink up front so all paths are canonical.
gtardif
approved these changes
May 28, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This is a clean, focused PR. The --app-name flag is correctly added to the runExecFlags struct and wired through tuiOpts() with an appropriate empty-string guard. The filepath.EvalSymlinks fix in the snapshot test is correct — there is no variable shadowing (the if-init err is scoped to that clause only), and t.TempDir() guarantees the directory exists for the test lifetime.
No confirmed bugs found in the changed code.
aheritier
added
area/cli
This was referenced May 29, 2026
aheritier
added a commit
that referenced
this pull request
May 29, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
docker agent runcommand now accepts an--app-nameflag to override the default "docker agent" label shown in the TUI. This string is passed to the existingtui.WithAppNameoption, affecting the status bar, terminal window title, and "/exit" notifications.We also fixed an unrelated test issue in
pkg/snapshot/snapshot_test.go. ThebootstrapRepohelper now resolves symlinks viafilepath.EvalSymlinkson its temporary directory. This ensures test assertions pass on macOS, wheret.TempDir()returns/var/folders/...(a symlink to/private/var/folders/...), whilegit rev-parse --show-toplevelreturns the canonical resolved path. This unblocksTestTrackPatchFromSubfolderandTestOpenCanonicalizesSymlinkedDirectory.