Skip to content

feat: add --app-name flag and fix macOS test symlink issue #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 2 commits into from
May 28, 2026
+9 −1
Merged

feat: add --app-name flag and fix macOS test symlink issue #2914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b9e2e6
feat: add --app-name flag to override TUI title
dgageot May 28, 2026
ac2ff3a
test(snapshot): canonicalize bootstrapRepo temp dir for macOS
dgageot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/root/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ type runExecFlags struct {
// Run only
hideToolResults bool
lean bool
appName string
listenAddr string
onEventSpecs []string

Expand Down Expand Up @@ -138,6 +139,7 @@ func addRunOrExecFlags(cmd *cobra.Command, flags *runExecFlags) {
cmd.PersistentFlags().BoolVar(&flags.forceTUI, "force-tui", false, "Force TUI mode even when not in a terminal")
_ = cmd.PersistentFlags().MarkHidden("force-tui")
cmd.PersistentFlags().BoolVar(&flags.lean, "lean", false, "Use a simplified TUI with minimal chrome")
cmd.PersistentFlags().StringVar(&flags.appName, "app-name", "", "Application name shown in the TUI in place of \"docker agent\"")
cmd.PersistentFlags().BoolVar(&flags.sandbox, "sandbox", false, "Run the agent inside a Docker sandbox (requires Docker Desktop with sandbox support)")
cmd.PersistentFlags().StringVar(&flags.sandboxTemplate, "template", "docker/sandbox-templates:docker-agent", "Template image for the sandbox (passed to docker sandbox create -t)")
cmd.PersistentFlags().BoolVar(&flags.sbx, "sbx", true, "Prefer the sbx CLI backend when available (set --sbx=false to force docker sandbox)")
Expand Down Expand Up @@ -498,6 +500,9 @@ func (f *runExecFlags) tuiOpts() []tui.Option {
if f.lean {
opts = append(opts, tui.WithLeanMode())
}
if f.appName != "" {
opts = append(opts, tui.WithAppName(f.appName))
}
return opts
}

Expand Down
5 changes: 4 additions & 1 deletion pkg/snapshot/snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,10 @@ func bootstrapRepo(t *testing.T) string {
if _, err := exec.LookPath("git"); err != nil {
t.Skip("git not available")
}
dir := t.TempDir()
// Canonicalize so paths match git rev-parse --show-toplevel, which
// resolves symlinks (e.g. /var/folders -> /private/var/folders on macOS).
dir, err := filepath.EvalSymlinks(t.TempDir())
require.NoError(t, err)
runGit(t, dir, "init")
runGit(t, dir, "config", "user.email", "test@example.com")
runGit(t, dir, "config", "user.name", "Test User")
Expand Down
Loading