chore(board): rename $BOARD_EDITOR to $DOCKER_AGENT_BOARD_EDITOR#3514
Merged
Conversation
Assisted-By: claude-opus-4-5
Assisted-By: Claude
docker-agent
reviewed
Jul 7, 2026
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This is a clean, well-structured rename of BOARD_EDITOR → DOCKER_AGENT_BOARD_EDITOR. The backward-compatibility fallback chain is correctly implemented in both the Go env lookup and the tmux shell expansion, and documentation is updated consistently. No bugs or regressions introduced.
gtardif
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The board feature lets users configure a preferred editor via an environment variable, but the original name
BOARD_EDITORis too generic and doesn't follow theDOCKER_AGENT_prefix convention used by the project's other env vars.This renames the variable to
DOCKER_AGENT_BOARD_EDITORacross the codebase and documentation. To avoid silently breaking existing setups, the oldBOARD_EDITORname is kept as a fallback for one release — both in the Go env lookup and in the tmux shell expansion (${DOCKER_AGENT_BOARD_EDITOR:-${BOARD_EDITOR:-code}}), matching the pattern already used for other renamed env vars in this project.Users relying on
BOARD_EDITORwill continue to see their editor launched without any change; they can migrate toDOCKER_AGENT_BOARD_EDITORat their own pace before the fallback is removed.