fix: preserve terminal and UTF-8 in sandbox plan editor - #3876
Merged
Conversation
trungutt
approved these changes
Jul 31, 2026
aheritier
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C.UTF-8locale that the sandbox template actually provides, preserving German and other non-ASCII inputIssue expectations
os.Stdin,os.Stdout, andos.StderrdirectlyLANG=C.UTF-8docker sandboxandsbxRoot cause
The TUI configures Bubble Tea with an image-aware output writer.
tea.ExecProcesspopulated an editor command's unset stdout with that writer, whichos/execexposed to Vim as a pipe rather than a terminal. Separately, the sandbox forceden_US.UTF-8, but the template only shipsC,C.utf8, andPOSIX; Vim consequently fell back tolatin1.Validation
task testtask --force linttask --force buildsbxmicroVM flow with the patched binary:/plans->e-> Vim -> enterViele Grüße äöüß->:wq-> plan updated from v1 to v2 with exact UTF-8 content and noOutput is not to a terminalwarningCloses #3873
Closes #3874