desktop: log and recover empty or failed token fetches - #3890
Merged
Conversation
trungutt
marked this pull request as ready for review
August 3, 2026 08:43
melmennaoui
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests through the Docker AI Gateway fail with
failed to get Docker Desktop token for Gateway. Is Docker Desktop running and are you signed in?whenever the token fetched from Docker Desktop comes back empty — yet this case leaves no trace anywhere: the fetch error was discarded, and unlike the expired-token case there was no log line and no recovery attempt.An empty result typically means Desktop's session exists but its read-time token refresh just failed (network blip, revoked refresh token) — the user is signed in, so the error message is misleading and there is nothing in the logs to attribute it to.
This PR makes the empty/failed fetch path behave like the expired path: