fix(skills): expire cache entries at deadline - #3896
Merged
Conversation
aheritier
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The Windows test in Actions run 30802380958, job 91649724192 failed because
TestDiskCache_Get_Expiredreceived a cache hit formax-age=0.Cache metadata is serialized to JSON, which removes Go's monotonic clock reading. On Windows, a subsequent wall-clock read can equal
ExpiresAt. The previous strictAftercomparison treated that boundary instant as fresh. Using an inclusive expiry check implementsnow >= ExpiresAtsemantics.Validation
go test -count=100 -run '^(TestDiskCache_Get_Expired|TestDiskCache_No(Store|Cache)StoresButExpiresImmediately)$' ./pkg/skillsgo test ./pkg/skillstask testtask linttask buildtask check-plan-crosspkg/skillstest binary