fix(runtime): guard nested agent delegation - #3905
Merged
Merged
Conversation
melmennaoui
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transfer_taskandrun_background_agentchains at 10 delegation edgesContext
This follows #3886, which establishes that agents started with
run_background_agentmay delegate to their own sub-agents. Supporting that pattern requires both termination guards and session-aware routing: a pinned background session must validate, attribute, and execute nested work as its pinned agent rather than the runtime's shared foreground agent.Issue expectations
validateDelegationrejects self-delegation before a child session startsa -> b -> atransfer_task,RunAgent, pinned sessions, concurrent nested transfers, and real async background handlersTest coverage
Runnercompatibility fallbackroot -> run_background_agent(worker) -> run_background_agent(helper) -> list/viewthrough the real dispatcher and detached goroutinesValidation
task testtask linttask build-race, including repeated async end-to-end runsCloses #3904
Related to #3886