test(runtime): isolate user config in tests - #3981
Merged
Merged
Conversation
TestMain reads userconfig.Get() indirectly via hooks.go's CacheStablePromptsEnabled() and loop.go's CacheMissWarningsEnabled(), which resolve through paths.GetConfigDir(). Without an override this silently loaded the developer's real ~/.config/cagent/config.yaml (cache_stable_prompts: true), so structured-output tests that assert on the injected transient-reminder cache marker failed nondeterministically depending on the machine's local settings. Extend TestMain to point paths.SetConfigDir at an empty temp directory for the whole package run, mirroring the pkg/httpclient precedent, so every runtime test observes library defaults instead of leaking local preferences.
Sayt-0
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/runtime tests now isolate the user config directory so local ~/.config/cagent settings cannot affect test outcomes.
Validation:
task testpassedtask lintpassedtask buildpassedcache_stable_promptsenabled.