Skip to content

fix(tui): retain interrupt confirmation setting - #3994

Merged
Sayt-0 merged 1 commit into
mainfrom
fix/3993-interrupt-confirmation
Aug 17, 2026
Merged

fix(tui): retain interrupt confirmation setting#3994
Sayt-0 merged 1 commit into
mainfrom
fix/3993-interrupt-confirmation

Conversation

@Sayt-0

@Sayt-0 Sayt-0 commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • retain the parsed interrupt confirmation mode in the top-level TUI model
  • pass the retained mode to initial, new, restored, and rebuilt chat pages
  • normalize and propagate settings changes to existing and future pages
  • add regression coverage for persisted startup state, settings application, and page recreation

Issue expectations

Expectation Implementation
none and double-tap survive restart Startup parses settings.interrupt_confirmation into appModel.interruptMode
New and rebuilt pages preserve the mode chatPageOpts() passes chat.WithInterruptMode(m.interruptMode)
Settings changes affect open and future tabs handleApplySettings() retains the normalized mode and updates every live chat page
Invalid values keep the safe default Values are normalized through ParseInterruptMode, falling back to always
Prevent regression Tests cover startup, existing-page propagation, future pages, and invalid values

Validation

  • task build
  • task test
  • task lint

Closes #3993

@Sayt-0
Sayt-0 requested a review from a team as a code owner August 17, 2026 07:26
@Sayt-0
Sayt-0 merged commit 9547449 into main Aug 17, 2026
15 checks passed
@Sayt-0
Sayt-0 deleted the fix/3993-interrupt-confirmation branch August 17, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interrupt confirmation setting is ignored on startup and when chat pages are rebuilt

2 participants