fix: update stale Fireworks kimi-k2-instruct model reference - #4145
Merged
Conversation
aheritier
marked this pull request as ready for review
September 3, 2026 14:58
aheritier
added
area/config
accounts/fireworks/models/kimi-k2-instruct does not exist in the fireworks-ai models.dev catalog and never has. Replace it with accounts/fireworks/models/kimi-k3, which is present in the current snapshot, across DefaultModels, examples/fireworks.yaml, tests, and the Fireworks provider docs (including the stale Available Models table, which also listed two other nonexistent ids). Also teach examples_test.go to resolve the actual models.dev catalog id for providers where it diverges from the docker-agent provider name (fireworks -> fireworks-ai, together -> togetherai, moonshot -> moonshotai, chatgpt -> openai, opencode-zen -> opencode) instead of unconditionally skipping validation, so this class of drift is caught automatically going forward. vercel now validates directly (models.dev catalogs it as-is); dmr/ovhcloud/cloudflare-* remain skipped with updated, accurate comments. Rebased onto main after #4147 (issue #4134/#4133) merged and added TestDefaultModelsExistInModelsDev, which validates DefaultModels directly against the models.dev provider id without the catalog-alias resolution above; apply the same modelsDevCatalogProviders mapping there so fireworks/together/moonshot/chatgpt/opencode-zen resolve correctly instead of failing on the raw docker-agent provider name. Fixes #4132
aheritier
force-pushed
the
fix/fireworks-model-reference
branch
from
September 3, 2026 16:40
e4a638e to
fe31efa
Compare
aheritier
enabled auto-merge
September 3, 2026 16:47
dgageot
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated implementer agent — this comment was posted by the implementer bot from Docker Agentic Platform, not by a human developer
Fixes #4132.
accounts/fireworks/models/kimi-k2-instructdoes not exist in thefireworks-aimodels.dev catalog (and never has). Replaces it withaccounts/fireworks/models/kimi-k3, verified present in the currentpkg/modelsdev/snapshot.json, across:pkg/config/auto.go(DefaultModels["fireworks"])examples/fireworks.yamlpkg/config/auto_test.go,pkg/model/provider/openai_alias_providers_test.go,pkg/model/provider/openai/system_message_merge_test.godocs/providers/fireworks/index.md— 4model:snippets, plus the "Available Models" table, which also listed two other nonexistent ids (llama-v3p3-70b-instruct,qwen3-235b-a22b); Llama has no successor in thefireworks-aicatalog at all, so it's dropped rather than remapped.Also closes the CI blind spot the issue describes:
pkg/config/examples_test.go'smodelsDevAbsentProvidersunconditionally skipped models.dev validation for several providers whose docker-agent name diverges from their models.dev catalog id. Replaced with amodelsDevCatalogProvidersmap that resolves the real catalog id (fireworks→fireworks-ai,together→togetherai,moonshot→moonshotai,chatgpt→openai,opencode-zen→opencode) before validating — this is exactly the check that would have caught #4132 automatically.vercelnow validates directly (models.dev catalogs it as-is).dmr,ovhcloud,cloudflare-workers-ai,cloudflare-ai-gatewayremain skipped with corrected comments (e.g.ovhcloud's example id is case-mismatched against models.dev's lower-cased ids, not "not yet catalogued").Known, deliberately out-of-scope follow-up:
DefaultModelsitself isn't validated against models.dev for every provider (e.g.github-copilot's defaultgpt-5.6isn't in that provider's catalog, which only hasgpt-5.6-luna/-sol/-terra). Extending validation toDefaultModelswould need separate model-choice review per provider, so left for a follow-up rather than bundled here.Testing:
task build,task test(green except the pre-existing, unrelatedpkg/rag/treesitterCGO failures — no gcc in this sandbox),task lint(golangci-lint +go run ./lint .+go mod tidy --diff) all pass.