[TAR-571] Remove the ads#106
Merged
seemethere merged 2 commits intodocker:masterfrom Mar 15, 2019
Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "remove_ads" git@github.com:seemethere/docker-install.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
russellcardullo
approved these changes
Mar 15, 2019
| 'aarch64-verify-install-ubuntu-xenial', | ||
| 'aarch64-verify-install-ubuntu-bionic', | ||
| 'aarch64-verify-install-centos-7', | ||
| 'aarch64-verify-install-fedora-29', |
Member
There was a problem hiding this comment.
Do we reintroduce the fedora 29?
Contributor
Author
There was a problem hiding this comment.
No unfortunately I think that was the side-effect of adding this on top of PR #95, going to re-apply that particular patch
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> (cherry picked from commit eabd8aa) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
duhruh
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 40b1b76, reversing
changes made to 26dda3d.