Skip to content

add ee promo#95

Merged
seemethere merged 3 commits intodocker:masterfrom
seemethere:ads
Feb 14, 2019
Merged

add ee promo#95
seemethere merged 3 commits intodocker:masterfrom
seemethere:ads

Conversation

@seemethere
Copy link
Copy Markdown
Contributor

No description provided.

@seemethere seemethere requested review from a team and thaJeztah February 14, 2019 18:27
@seemethere seemethere changed the title add ads ¯\_(ツ)_/¯ add ee promo Feb 14, 2019
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
Copy link
Copy Markdown

@duhruh duhruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although it shows up on Raspbian)

Comment thread install.sh
echo
echo " sudo docker engine activate"
echo
sleep 10
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the sleep necessary?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for "visibility"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sleep is followed by an exit so it would be the last thing seen before returning to a prompt, and thus left on screen unless the user did some kind of reset or clear in sequence.

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere seemethere merged commit 40b1b76 into docker:master Feb 14, 2019
seemethere added a commit to seemethere/docker-install that referenced this pull request Mar 15, 2019
This reverts commit 40b1b76, reversing
changes made to 26dda3d.
seemethere added a commit to seemethere/docker-install that referenced this pull request Mar 15, 2019
This reverts commit 40b1b76, reversing
changes made to 26dda3d.

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere seemethere deleted the ads branch August 28, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants