Skip to content

Conversation

@aevesdocker
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6610966
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6315bed3c90e7c0008cb1809
😎 Deploy Preview https://deploy-preview-15350--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Allie!!

- Column and row headers in tables
- Links
- Sentences (of course)
- Anything in the Ul including navigation labels, buttons, headings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Anything in the Ul including navigation labels, buttons, headings
- Anything in the Ul including navigation labels, buttons, headings. Provided that the corresponding UI label uses sentence case; follow the capitalization style of the UI element.

Comment on lines +154 to +155
- Use the em dash (-) sparingly when you want the reader to pause, to create parenthetical statements, or to emphasize specific words or phrases. Always put a space on either side of the em dash.
- Use an en dash (-) to indicate spans of numbers, dates, or time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally I know which one to use where 👍🏻 :-D

path: /contribute/overview/
node: contribute
# TODO unify navbbar links: homepage currently has a custom "articles" link
hide_home: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should hide the contribute section from the landing page. But, it looks like that would also require some CSS changes, too. The home page already contains the additional "Articles" link, and adding contribute as well makes it rather wide. The media query looks like it's set to collapse the nav menu at 768px, which is narrower than the width of the navbar if we also add contribute.

Easy solution would be to remove the Articles (blog) link. Do we really need it? :D

@dvdksn
Copy link
Contributor

dvdksn commented Sep 2, 2022

Also we might want to update CONTRIBUTING.md, and just put a link to the contribution section in there. I think that's better than removing the file entirely.

@aevesdocker aevesdocker marked this pull request as ready for review September 3, 2022 13:22
@aevesdocker aevesdocker changed the title SG test. Addition of a 'Contribute' section with our Style Guide Sep 5, 2022
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@aevesdocker aevesdocker merged commit 5291295 into docker:master Sep 5, 2022
aevesdocker added a commit that referenced this pull request Sep 5, 2022
* Update mac-install.md (#15555)

Typo in spelling of subscription. `subscri[tion` -> `subscription`

* Addition of a 'Contribute' section with our Style Guide (#15350)

* SG test.

* moved some content around

* editing

* broken links fix

* formatting changes

* fixes

* fixes

* edits after review

* fix broken links

* broken link fix

* a few more edits

* removed contributing page

* Revert "removed contributing page"

This reverts commit 5822cd5.

* add redirect

* Install page improvement based on feedback (scenario2) (#15494)

* Install page improvement based on users and PM feedback
* Exploring a second scenario deriving from additional feedback
* Review feedback

* contribute edit (#15565)

Co-authored-by: Clint Joseph <clintjoseph1992@gmail.com>
Co-authored-by: Dockertopia <103652162+dockertopia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants