- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8k
Addition of a 'Contribute' section with our Style Guide #15350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables 
 To edit notification comments on pull requests, go to your Netlify site settings. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Allie!!
| - Column and row headers in tables | ||
| - Links | ||
| - Sentences (of course) | ||
| - Anything in the Ul including navigation labels, buttons, headings | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Anything in the Ul including navigation labels, buttons, headings | |
| - Anything in the Ul including navigation labels, buttons, headings. Provided that the corresponding UI label uses sentence case; follow the capitalization style of the UI element. | 
| - Use the em dash (-) sparingly when you want the reader to pause, to create parenthetical statements, or to emphasize specific words or phrases. Always put a space on either side of the em dash. | ||
| - Use an en dash (-) to indicate spans of numbers, dates, or time. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally I know which one to use where 👍🏻 :-D
| path: /contribute/overview/ | ||
| node: contribute | ||
| # TODO unify navbbar links: homepage currently has a custom "articles" link | ||
| hide_home: true | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should hide the contribute section from the landing page. But, it looks like that would also require some CSS changes, too. The home page already contains the additional "Articles" link, and adding contribute as well makes it rather wide. The media query looks like it's set to collapse the nav menu at 768px, which is narrower than the width of the navbar if we also add contribute.
Easy solution would be to remove the Articles (blog) link. Do we really need it? :D
| Also we might want to update CONTRIBUTING.md, and just put a link to the contribution section in there. I think that's better than removing the file entirely. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Update mac-install.md (#15555) Typo in spelling of subscription. `subscri[tion` -> `subscription` * Addition of a 'Contribute' section with our Style Guide (#15350) * SG test. * moved some content around * editing * broken links fix * formatting changes * fixes * fixes * edits after review * fix broken links * broken link fix * a few more edits * removed contributing page * Revert "removed contributing page" This reverts commit 5822cd5. * add redirect * Install page improvement based on feedback (scenario2) (#15494) * Install page improvement based on users and PM feedback * Exploring a second scenario deriving from additional feedback * Review feedback * contribute edit (#15565) Co-authored-by: Clint Joseph <clintjoseph1992@gmail.com> Co-authored-by: Dockertopia <103652162+dockertopia@users.noreply.github.com>

No description provided.