contribute edit #15565
Merged
contribute edit #15565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
dvdksn
approved these changes
Sep 5, 2022
crazy-max
reviewed
Sep 5, 2022
| ## Copyright and license | ||
|
|
||
| Copyright 2013-2022 Docker, inc, released under the Apache 2.0 license. | ||
| We have created a ['Contribute' section](/contribute/overview.md) in our docs which guides you through the process of contributing to Docker documentation. |
There was a problem hiding this comment.
It might have been better to put the full link for contributing overview otherwise contributors will see internal markdown of GitHub with frontmatter stuff and bad formatting:
Smth like:
['Contribute' section]({{ site.docs_url }}/contribute/overview/)
This way contributors from GitHub or docs website will have the same layout.
There was a problem hiding this comment.
Oh actually it will not work as GitHub does not handle liquid syntax in their markdown 😣
There was a problem hiding this comment.
Ah, thanks for spotting this Kevin. Have amended in #15567
aevesdocker
added a commit
that referenced
this pull request
Sep 5, 2022
* Update mac-install.md (#15555) Typo in spelling of subscription. `subscri[tion` -> `subscription` * Addition of a 'Contribute' section with our Style Guide (#15350) * SG test. * moved some content around * editing * broken links fix * formatting changes * fixes * fixes * edits after review * fix broken links * broken link fix * a few more edits * removed contributing page * Revert "removed contributing page" This reverts commit 5822cd5. * add redirect * Install page improvement based on feedback (scenario2) (#15494) * Install page improvement based on users and PM feedback * Exploring a second scenario deriving from additional feedback * Review feedback * contribute edit (#15565) Co-authored-by: Clint Joseph <clintjoseph1992@gmail.com> Co-authored-by: Dockertopia <103652162+dockertopia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.