Skip to content

Install page improvement based on feedback (scenario2) #15494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 5, 2022
Merged

Install page improvement based on feedback (scenario2) #15494

merged 14 commits into from
Sep 5, 2022

Conversation

@dockertopia
Copy link
Contributor

@dockertopia dockertopia commented Aug 26, 2022 •
edited
Loading

Exploring @thaJeztah's feedback on this. Here's a second scenario:

  • Giving more prominence to DD.
  • Trying to portray more Compose as something you get with Docker.
  • Including @hyu's feedback.

Proposed changes

From scenario 1 POV:

  • Changing the page flow, 1) to Linux (only plugin), 2) other installs (standalone per system).
  • Including About DD image

Related PR

Scenario 1: #15487

@dockertopia dockertopia requested a review from hyu August 26, 2022 12:55
@netlify
Copy link

netlify bot commented Aug 26, 2022 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f5a65b
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63121798bb317d00080ad173
😎 Deploy Preview https://deploy-preview-15494--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dockertopia
Copy link
Contributor Author

@han to be good on my word, I wanted to consider thaJezta's feedback in a new scenario. Ths leaves you to appreciate all the information I've presented with so far. Although I would love if we could conclude this discussion as soon as possible and move forwards with publishing a fully reviewed version of this in the next 1-2 work days.

@dockertopia dockertopia mentioned this pull request Aug 26, 2022
Closed
@dockertopia dockertopia changed the title Engdocs 906 scenario2 Install page improvement based on feedback (scenario2) Aug 29, 2022
@dockertopia dockertopia marked this pull request as ready for review August 29, 2022 13:08
hyu
hyu reviewed Aug 29, 2022
View reviewed changes
hyu
hyu reviewed Aug 29, 2022
View reviewed changes
hyu
hyu reviewed Aug 29, 2022
View reviewed changes
hyu
hyu previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@hyu hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dora! I approve these changes to the page. I added some comments that are non-blocking. (They are minor. And to avoid too much delay from async communication if any of my points are controversial, I want you to go ahead and merge without changes so the bias can be on moving quickly).

dockertopia and others added 2 commits August 29, 2022 16:31
@dockertopia @hyu
Update _data/toc.yaml
5f5b017 
Title adjustment

Co-authored-by: Han Yu <han@sent.com>
@dockertopia
Merge branch 'ENGDOCS-906-scenario2' of https://github.com/dockertopi…
54fed1a 
…a/docker.github.io into ENGDOCS-906-scenario2
@dockertopia dockertopia requested a review from hyu August 29, 2022 15:34
thaJeztah
thaJeztah reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like this (but I may be biased 😅) Left some thoughts / ramblings 😂

@StefanScherer
Copy link
Member

For the about box screenshot compose/images/about_desktop.png it would be good to have Compose V2 version shown instead of the 1.29.2 V1 version. :-)

usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
hyu
hyu previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@hyu hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
usha-mandya
usha-mandya reviewed Sep 2, 2022
View reviewed changes
@dockertopia
Copy link
Contributor Author

For the about box screenshot compose/images/about_desktop.png it would be good to have Compose V2 version shown instead of the 1.29.2 V1 version. :-)

@Stefan an image with placeholder text for the versions was added instead.

@dockertopia dockertopia requested a review from hyu September 2, 2022 15:26
hyu
hyu approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@hyu hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

StefanScherer
StefanScherer approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockertopia dockertopia merged commit ef28f70 into docker:master Sep 5, 2022
aevesdocker added a commit that referenced this pull request Sep 5, 2022
@aevesdocker @clintjoseph1992 @dockertopia
Publish updates from master (#15566)
830732a 
* Update mac-install.md (#15555)

Typo in spelling of subscription. `subscri[tion` -> `subscription`

* Addition of a 'Contribute' section with our Style Guide (#15350)

* SG test.

* moved some content around

* editing

* broken links fix

* formatting changes

* fixes

* fixes

* edits after review

* fix broken links

* broken link fix

* a few more edits

* removed contributing page

* Revert "removed contributing page"

This reverts commit 5822cd5.

* add redirect

* Install page improvement based on feedback (scenario2) (#15494)

* Install page improvement based on users and PM feedback
* Exploring a second scenario deriving from additional feedback
* Review feedback

* contribute edit (#15565)

Co-authored-by: Clint Joseph <clintjoseph1992@gmail.com>
Co-authored-by: Dockertopia <103652162+dockertopia@users.noreply.github.com>
@dockertopia dockertopia mentioned this pull request Sep 7, 2022
Closed
@crazy-max crazy-max mentioned this pull request Sep 11, 2022
Merged
@hyu hyu mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanScherer StefanScherer StefanScherer approved these changes

@aevesdocker aevesdocker aevesdocker approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@usha-mandya usha-mandya Awaiting requested review from usha-mandya

+1 more reviewer

@hyu hyu hyu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dockertopia @StefanScherer @hyu @thaJeztah @usha-mandya @aevesdocker