Skip to content

Conversation

@craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Dec 2, 2024

Description

  • Added topic for archive or activate a repository
  • Updated repo landing page topic to add new archive topic
  • Added note to repo information topic

Modified pages:

Related issues or tickets

ENGDOCS-2337

Reviews

  • Technical review
  • Editorial review
  • Product review

Signed-off-by: Craig <craig.osterhout@docker.com>
@github-actions github-actions bot added the area/hub Issue affects Docker Hub label Dec 2, 2024
@netlify
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4418ff1
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6752277b7306200008f13af5
😎 Deploy Preview https://deploy-preview-21553--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Craig <craig.osterhout@docker.com>
@craig-osterhout
Copy link
Contributor Author

Pending UI wording changes.

Signed-off-by: Craig <craig.osterhout@docker.com>
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let one nit for a clarity rewording

Signed-off-by: Craig <craig.osterhout@docker.com>
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivan-curkovic
Copy link
Contributor

ivan-curkovic commented Dec 4, 2024

We have updated the UI copy to say "Unarchive" instead of "Activate"
image
@craig-osterhout

Signed-off-by: Craig <craig.osterhout@docker.com>
Copy link
Contributor

@ivan-curkovic ivan-curkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@craig-osterhout craig-osterhout added status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. and removed status/review labels Dec 6, 2024
@ivan-curkovic
Copy link
Contributor

can we merge this @craig-osterhout? We want to release the feature.

@craig-osterhout craig-osterhout merged commit 8a805f4 into docker:main Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hub Issue affects Docker Hub area/tests status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants