sbx: document SOCKS5 upstream proxy and DOCKER_SANDBOXES_NO_PROXY#25537
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The documentation update is accurate, well-scoped, and clean. The SOCKS5 proxy support and variable are correctly documented, including the vs DNS resolution distinction, credential embedding syntax, and the relationship with /. No AI-isms, markdown issues, or bold misuse found.
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR cleanly documents new SOCKS5 upstream proxy support and the companion DOCKER_SANDBOXES_NO_PROXY variable. The writing is clear, factual, and matches the existing document's tone and scope. No AI-isms, marketing language, or style violations were found. The removal of the HTTP/HTTPS-only limitation bullet is technically accurate — SOCKS5 operates at the transport layer and supports generic TCP proxying, so the limitation genuinely no longer applies.
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR cleanly documents two new features in Sandboxes v0.35.0: SOCKS5 upstream proxy support and the DOCKER_SANDBOXES_NO_PROXY variable. The prose is concise, technically accurate, and free of AI-isms or marketing language. No structural or formatting issues found.
One minor suggestion is left as an inline comment.
|
|
||
| Set `DOCKER_SANDBOXES_NO_PROXY` to exclude specific destinations from | ||
| `DOCKER_SANDBOXES_PROXY`, using standard comma-separated `NO_PROXY` matching | ||
| semantics. This only affects traffic routed through `DOCKER_SANDBOXES_PROXY` |
There was a problem hiding this comment.
[LOW] Em dash joins two independent clauses (semicolon-equivalent usage)
The em dash on this line effectively joins two independent clauses the same way a semicolon would — which the style guide discourages (it advises writing two sentences instead). Consider splitting:
This only affects traffic routed through
DOCKER_SANDBOXES_PROXY. UseNO_PROXYto exclude destinations fromHTTP_PROXY/HTTPS_PROXY.
Description
v0.35.0 adds SOCKS5 upstream proxy support and a companion exclusion variable.
Release notes: https://github.com/docker/sandboxes/releases/tag/v0.35.0
Upstream changes: docker/sandboxes#4041 (SOCKS5 transport),
docker/sandboxes#4056 (DOCKER_SANDBOXES_NO_PROXY)
Updates the "Upstream proxy" section of
architecture.md:socks5://andsocks5h://scheme support, including theDNS resolution distinction between the two
socks5://user:pass@host:port)DOCKER_SANDBOXES_NO_PROXYwith a note clarifying it applies onlyto
DOCKER_SANDBOXES_PROXYtraffic, notHTTP_PROXY/HTTPS_PROXYbullet, which is no longer accurate with SOCKS5
Related issues or tickets
Reviews