This repository was archived by the owner on Sep 29, 2025. It is now read-only.
Conversation
- introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <emily.casey@docker.com>
Signed-off-by: Emily Casey <emily.casey@docker.com>
ilopezluna
reviewed
May 12, 2025
| return mdpartial.Descriptor(m) | ||
| } | ||
|
|
||
| func (m *Model) GGUFPath() (string, error) { |
Contributor
There was a problem hiding this comment.
how the gguf file will be found in model-runner without this?
Contributor
Author
There was a problem hiding this comment.
I left this function on types.Model interface (the type returned from the client) but removed it from the types.ModelArtifact interface. So, a model returned from the store will have a local gguf file accessible but this isn't guaranteed for any artifact we are manipulating (e.g. an aritfact in the registry). In this particular case we could implement this, but we don't actually have a need for it.
xenoscopic
approved these changes
May 12, 2025
Contributor
xenoscopic
left a comment
xenoscopic
left a comment
There was a problem hiding this comment.
I'm admittedly just reviewing from a syntactical / code standpoint - I can't speak much to the business logic here. Overall it seems cleaner and LGTM!
ilopezluna
approved these changes
May 12, 2025
doringeman
pushed a commit
to docker/model-runner
that referenced
this pull request
Sep 23, 2025
* Provides API for packaging models - introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <emily.casey@docker.com> * cleanup Signed-off-by: Emily Casey <emily.casey@docker.com> * slim down artifact interface Signed-off-by: Emily Casey <emily.casey@docker.com> * cleanup Signed-off-by: Emily Casey <emily.casey@docker.com> --------- Signed-off-by: Emily Casey <emily.casey@docker.com>
doringeman
pushed a commit
to docker/model-runner
that referenced
this pull request
Sep 23, 2025
* Provides API for packaging models - introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <emily.casey@docker.com> * cleanup Signed-off-by: Emily Casey <emily.casey@docker.com> * slim down artifact interface Signed-off-by: Emily Casey <emily.casey@docker.com> * cleanup Signed-off-by: Emily Casey <emily.casey@docker.com> --------- Signed-off-by: Emily Casey <emily.casey@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registrypackage that allow client code to fetch artifacts from registry.For example usage see cmdPackage in
main.gofor mdtool.