Conversation
xenoscopic
approved these changes
May 12, 2025
Contributor
xenoscopic
left a comment
xenoscopic
left a comment
There was a problem hiding this comment.
LGTM (pending docker/model-distribution#74 and a final dep update).
Signed-off-by: Emily Casey <emily.casey@docker.com>
ekcasey
force-pushed
the
bump-model-distribution
branch
from
d598b57 to
f79622e
Compare
ericcurtin
referenced
this pull request
in ericcurtin/model-runner
Sep 21, 2025
Don't require tool name in backfill behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/model-distribution#74 required some moving of error types. This PR bumps model-distribution and updates to use
registry.Err*to check registry related errors.