Skip to content

fix(standalone): make render group addition non-fatal #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 1 commit into from
Oct 27, 2025
Merged

fix(standalone): make render group addition non-fatal #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions cmd/cli/pkg/standalone/containers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,14 +334,21 @@ func CreateControllerContainer(ctx context.Context, dockerClient *client.Client,
if runtime.GOOS == "linux" {
out, err := exec.CommandContext(ctx, "getent", "group", "render").CombinedOutput()
if err != nil {
return fmt.Errorf("failed to retrieve the GID of 'render': %w", err)
}
tokens := strings.Split(string(out), ":")
gid, err := strconv.Atoi(tokens[2])
if err != nil {
return fmt.Errorf("failed to parse the GID of 'render': %w", err)
printer.Printf("Warning: render group not found, skipping group addition\n")
} else {
trimmedOut := strings.TrimSpace(string(out))
tokens := strings.Split(trimmedOut, ":")
if len(tokens) < 3 {
printer.Printf("Warning: unexpected getent output format: %q\n", trimmedOut)
} else {
gid, err := strconv.Atoi(tokens[2])
if err != nil {
printer.Printf("Warning: failed to parse render GID from %q: %v\n", tokens[2], err)
} else {
hostConfig.GroupAdd = append(hostConfig.GroupAdd, strconv.Itoa(gid))
}
}
}
hostConfig.GroupAdd = append(hostConfig.GroupAdd, strconv.Itoa(gid))
}

// Create the container. If we detect that a concurrent installation is in
Expand Down
Loading