Improve error handling on large blob downloads#1
Merged
Conversation
Improve error handling on large blob downloads
tianon-sso
approved these changes
Apr 14, 2026
tianon-sso
left a comment
tianon-sso
left a comment
Member
There was a problem hiding this comment.
The repeated cancel() and wg.Wait() bits seem like a code smell, but maybe not worth an explicit block on the merge? (might be worth double checking for race issues in the future)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds timeout to each ranged get so that if the connection stalls, we quit and retry.
Also propagates other read errors back to the coordinating worker so that if a worker fails, it still retries.