docs: fix broken contribution workflow link in project-template - #128
Open
Gaalbu wants to merge 1 commit into
Open
docs: fix broken contribution workflow link in project-template#128Gaalbu wants to merge 1 commit into
Gaalbu wants to merge 1 commit into
Conversation
Signed-off-by: Gaalbu <gabrielalbuquerquealencar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #126.
The "Understand how to contribute" link in
project-template/CONTRIBUTING.mdpointed to
https://docs.docker.com/opensource/workflow/make-a-contribution/,which returns 404.
Investigation
The entire
/opensource/section this page belonged to has been removed fromdocs.docker.com — it's absent from the current sitemap and there's no
successor page under that path. A previous attempt at this fix (#127) replaced
the link with
https://docs.docker.com/contribute/, but that URL also 404s(verified with
curl), which is likely why it didn't get merged.Since no equivalent contribution-workflow page currently exists on Docker
Docs, I replaced the link with
https://github.com/moby/moby/blob/master/CONTRIBUTING.md(verified 200 OK) — a live, in-depth contribution guide covering the same
ground (dev setup, PR process, DCO). It's also consistent with the rest of
the paragraph, which already links to
docker/docker(auto-redirects tomoby/moby) for the sibling guidelines/triage/review docs.Testing
curl -o /dev/null -s -w "%{http_code}" https://docs.docker.com/opensource/workflow/make-a-contribution/→ 404 (confirms original issue)curl -o /dev/null -s -w "%{http_code}" https://docs.docker.com/contribute/→ 404 (confirms why docs: fix contribution guide link #127 didn't resolve the issue)curl -o /dev/null -s -w "%{http_code}" -L https://github.com/moby/moby/blob/master/CONTRIBUTING.md→ 200 (new link works)