Conversation
joe0BAB
force-pushed
the
refactor/pass
branch
from
785b52e to
b9f60c5
Compare
…d on "go list" output
Benehiko
previously approved these changes
Jan 16, 2026
Benehiko
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
passplugin into thepluginsfolder for consistency. Additionally, replaces the hardcoded list for the unit tests with a for loop around the output ofgo list(TIL about secondary expansion https://www.gnu.org/software/make/manual/html_node/Secondary-Expansion.html. Essentially the make snippet gets processed twice. The result of the first pass gets passed to a shell and the $$ turns into $ for the second pass)