Skip to content

refactor(pass): move into plugins folder #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joe0BAB merged 3 commits into from
Jan 16, 2026
Merged

refactor(pass): move into plugins folder #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f60c5
refactor(pass): move into plugins folder
joe0BAB Jan 16, 2026
408fd4d
feat: replace hardcoded list of unit tests with dynamic for loop base…
joe0BAB Jan 16, 2026
4a762a3
fix: skip store tests in main unit tests run
joe0BAB Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,16 @@ lint: multiarch-builder ## Lint code
clean: ## remove built binaries and packages
@sh -c "rm -rf bin dist"

.PHONY: unit-tests
unit-tests:
pids=""; \
err=0; \
go test -trimpath -race -v $(shell go list ./client/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./cmd/engine/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./cmd/pass/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./engine/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./injector/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./pass/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./plugin/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./plugins/credentialhelper/...) & pids="$$pids $$!"; \
go test -trimpath -race -v $(shell go list ./x/...) & pids="$$pids $$!"; \
for dir in $(shell go list -f '{{.Dir}}' -m); do \
case "$$dir" in \
*/store) continue ;; \
esac; \
go test -trimpath -race -v $$(go list "$$dir/...") & pids="$$pids $$!"; \
done; \
for p in $$pids; do \
wait $$p || err=$$?; \
done; \
Expand Down Expand Up @@ -184,4 +182,4 @@ help: ## Show this help
@echo Please specify a build target. The choices are:
@grep -E '^[0-9a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "$(INFO_COLOR)%-30s$(NO_COLOR) %s\n", $$1, $$2}'

.PHONY: run bin format lint proto-lint proto-generate unit-tests clean help keychain-linux-unit-tests keychain-unit-tests pass pass-cross engine engine-cross
.PHONY: run bin format lint proto-lint proto-generate clean help keychain-linux-unit-tests keychain-unit-tests pass pass-cross engine engine-cross
2 changes: 1 addition & 1 deletion cmd/engine/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ go 1.25.0
// retrieved using `go get`.
replace github.com/docker/secrets-engine/engine => ../../engine

replace github.com/docker/secrets-engine/pass => ../../pass
replace github.com/docker/secrets-engine/pass => ./../../plugins/pass

replace github.com/docker/secrets-engine/plugins/credentialhelper => ../../plugins/credentialhelper/

Expand Down
2 changes: 1 addition & 1 deletion cmd/pass/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ go 1.25.0
// retrieved using `go get`.
replace github.com/docker/secrets-engine/engine => ../../engine

replace github.com/docker/secrets-engine/pass => ../../pass
replace github.com/docker/secrets-engine/pass => ./../../plugins/pass

replace github.com/docker/secrets-engine/store => ../../store

Expand Down
2 changes: 1 addition & 1 deletion go.work
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ use (
./cmd/pass
./engine
./injector
./pass
./plugin
./plugins/credentialhelper
./plugins/pass
./store
./x
)
0 pass/command.go → plugins/pass/command.go
View file
Open in desktop
File renamed without changes.
0 pass/command_test.go → plugins/pass/command_test.go
View file
Open in desktop
File renamed without changes.
0 pass/commands/get.go → plugins/pass/commands/get.go
View file
Open in desktop
File renamed without changes.
0 pass/commands/list.go → plugins/pass/commands/list.go
View file
Open in desktop
File renamed without changes.
0 pass/commands/rm.go → plugins/pass/commands/rm.go
View file
Open in desktop
File renamed without changes.
0 pass/commands/set.go → plugins/pass/commands/set.go
View file
Open in desktop
File renamed without changes.
0 pass/commands/version.go → plugins/pass/commands/version.go
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions pass/go.mod → plugins/pass/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ module github.com/docker/secrets-engine/pass

go 1.25.0

replace github.com/docker/secrets-engine/store => ../store
replace github.com/docker/secrets-engine/store => ./../../store

replace github.com/docker/secrets-engine/x => ../x
replace github.com/docker/secrets-engine/x => ./../../x

require (
github.com/docker/secrets-engine/plugin v0.0.19
Expand Down
0 pass/go.sum → plugins/pass/go.sum
View file
Open in desktop
File renamed without changes.
0 pass/plugin.go → plugins/pass/plugin.go
View file
Open in desktop
File renamed without changes.
0 pass/plugin_test.go → plugins/pass/plugin_test.go
View file
Open in desktop
File renamed without changes.
0 pass/store/store.go → plugins/pass/store/store.go
View file
Open in desktop
File renamed without changes.
0 pass/teststore/teststore.go → plugins/pass/teststore/teststore.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ github.com/docker/go-units
## explicit; go 1.25
# github.com/docker/secrets-engine/engine v0.0.28 => ./engine
## explicit; go 1.25.0
# github.com/docker/secrets-engine/pass v0.0.15 => ./pass
# github.com/docker/secrets-engine/pass v0.0.15 => ./plugins/pass
## explicit; go 1.25.0
# github.com/docker/secrets-engine/plugin v0.0.19 => ./plugin
## explicit; go 1.25
Expand Down
Loading