Documentation cleanup#426
Merged
Merged
Conversation
AgneCaunt
previously approved these changes
Sep 30, 2025
| The main thread will interact with the services by using the client | ||
| @docknetwork/wallet-sdk-core/lib/client | ||
|
|
||
| Notice that the `modules` folder is running in the main thread (react native) and will be using the json rpc client (`@docknetwork/wallet-sdk-core/lib/client`) to interact with `@docknetwork/wallet-sdk-core/lib/service` methods |
Collaborator
There was a problem hiding this comment.
the files @docknetwork/wallet-sdk-core/lib/client and @docknetwork/wallet-sdk-core/lib/service doesn't exist.
The proper path should be:
@docknetwork/wallet-sdk-wasm/lib/services/[moduleName]/service-rpc to interact with @docknetwork/wallet-sdk-wasm/lib/services/[moduleName]/service.js
Contributor
Author
There was a problem hiding this comment.
I updated the guidance. Please check to see if I understood correctly.
Collaborator
|
Looks good, just a minor change required for JSON-RPC implementation path |
maycon-mello
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistently using npm
Removing notes about tokens and Polkadot
Improving organization of files
Edits for clarity