feat(i18n): add Korean (ko) translation#170
Merged
Merged
Conversation
Add ko.json for the core UI theme (sidebar, search, 404, cookie consent, language/version switchers) and for the search, git, and threads plugins, following the existing locale pattern used by en/de/es/fr/ja/zh/hi. All translation files are dynamically loaded by locale id at runtime, so no additional registration was required.
mgks
added a commit
that referenced
this pull request
Jul 9, 2026
Add ko.json for the core UI theme (sidebar, search, 404, cookie consent, language/version switchers) and for the search, git, and threads plugins, following the existing locale pattern used by en/de/es/fr/ja/zh/hi. All translation files are dynamically loaded by locale id at runtime, so no additional registration was required. Co-authored-by: moduvoice <moduvoicr77@gmail.com>
Member
|
Thank you so much for the contribution. 🙏🏼 I deleted the Users can now simply use the Korean translations by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
(한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.)
docmdalready ships built-in UI strings for the documentation sites it generates(sidebar/navigation labels, search, cookie consent, the
githistory widget, and thethreadsdiscussion plugin), with translations foren,de,es,fr,ja,zh,and
hi. This PR adds the missingkolocale so Korean-language docs sites built withdocmdrender their built-in UI chrome in Korean instead of falling back to English.Changes
packages/ui/translations/ko.json— core theme strings (sidebar, search, 404 page,cookie consent, language/version switchers, etc.) — 44 keys
packages/plugins/search/i18n/ko.json— search plugin UI strings — 8 keyspackages/plugins/git/i18n/ko.json— git history widget strings — 11 keyspackages/plugins/threads/i18n/ko.json— threads/discussion plugin strings — 42 keysNo source/registration changes were needed: each package resolves translation files by
locale id at runtime (
packages/ui/src/index.ts, and the equivalent loaders in thesearch/gitplugins), falling back toenfor missing keys, so simply adding theko.jsonfiles is sufficient to enable the locale — the same pattern used by theexisting
hi/zh/ja/de/es/frlocales.Testing
kokey set is identical to the correspondingen.jsonin all fourfiles (no missing/extra keys) via a small script comparing
Object.keys.{placeholder}tokens (e.g.{active},{default},{version},{n}) are preserved exactly in the Korean strings.consistent with the terminology used across the existing UI strings.