Skip to content

Conversation

@skatkov
Copy link

@skatkov skatkov commented Sep 4, 2022

Daemonization was removed from puma in 5.x version, so for this project to work locally - I had to lock puma to last 4.x version.

Here is an error i'm receiving when I try to run this locally:

> bundle exec rake server:start
>> Removing index cache pages
Traceback (most recent call last):
	14: from /home/stas/.rvm/gems/ruby-2.7.4/bin/ruby_executable_hooks:22:in `<main>'
	13: from /home/stas/.rvm/gems/ruby-2.7.4/bin/ruby_executable_hooks:22:in `eval'
	12: from /home/stas/.rvm/gems/ruby-2.7.4/bin/puma:23:in `<main>'
	11: from /home/stas/.rvm/gems/ruby-2.7.4/bin/puma:23:in `load'
	10: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/bin/puma:8:in `<top (required)>'
	 9: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/bin/puma:8:in `new'
	 8: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/cli.rb:72:in `initialize'
	 7: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/cli.rb:72:in `new'
	 6: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/launcher.rb:60:in `initialize'
	 5: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/configuration.rb:219:in `load'
	 4: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/configuration.rb:219:in `each'
	 3: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/configuration.rb:219:in `block in load'
	 2: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/dsl.rb:83:in `_load_from'
	 1: from /home/stas/.rvm/gems/ruby-2.7.4/gems/puma-5.6.4/lib/puma/dsl.rb:83:in `instance_eval'
scripts/puma.rb:9:in `_load_from': undefined local variable or method `daemonize' for #<Puma::DSL:0x00005592d6f2c858> (NameError)

@lsegal
Copy link
Collaborator

lsegal commented Sep 4, 2022

It might make more sense just to remove the daemonize line since it's not used in full deployment either. That seems better than regressing on versions.

@skatkov
Copy link
Author

skatkov commented Sep 5, 2022

@lsegal this is indeed a better idea. I changed my PR accordingly, would appreciate another review.

@skatkov skatkov changed the title Chore: lock puma to 4.x version Chore: remove puma daemonization Sep 5, 2022
@skatkov skatkov changed the title Chore: remove puma daemonization Chore: remove puma daemonize mode, not supported anymore Sep 5, 2022
@skatkov skatkov changed the title Chore: remove puma daemonize mode, not supported anymore Remove puma daemonize mode, not supported anymore Sep 5, 2022
@lsegal lsegal force-pushed the main branch 2 times, most recently from d5989ee to d636326 Compare May 9, 2025 05:26
@lsegal
Copy link
Collaborator

lsegal commented May 12, 2025

We've recently migrated to Rails and this PR is now obsolete, so I'm going to close it. We appreciate the PR, hopefully this type of thing is no longer necessary!

@lsegal lsegal closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants