build(deps): remove unused lru-cache dependency - #256
Merged
sy-records merged 1 commit intoAug 4, 2026
Conversation
sy-records
approved these changes
Aug 4, 2026
sy-records
left a comment
Member
There was a problem hiding this comment.
Thanks.
It was previously referenced in SSR, but now that SSR has been removed, it is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lru-cache@^5.1.1is declared independenciesbut is not imported anywhere in theproject. Its only occurrence in the whole repository is the
package.jsonline itself.Everyone who installs
docsify-cligets it, and nothing ever loads it.Verified at b9d118f on Node 20.20.0 / npm 10.8.2, Windows:
git grep -E "(from|require\(|import\()\s*['\"]lru-cache"returns nothing, and a plaingit grepforlru-cacheorLRUoutside the lockfile matches onlypackage.json:61.npm run build(rollup) after the change: exit 0,lib/cli.js → bin/docsifycreated asbefore. Nothing was being bundled from it either.
npm testbefore the change: 9 tests failed. After the change: 9 tests failed. Theset of failing titles is identical, diffed rather than counted:
Those 9 are pre-existing on this machine and unrelated to this change — they are the
e2e tests that shell out, and they fail the same way on a clean checkout.
pretestrunseslint ., which is clean on both sides.npm installreportsremoved 2 packages:lru-cacheandyallist, which came in onlyas its dependency.
I have not touched anything else. If you would rather I re-run the suite somewhere the e2e
tests pass before this is merged, I'm happy to, but the failing set being identical is what
tells you the change is inert.