Skip to content

[Install] Some updates #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2015
Merged

[Install] Some updates #4

merged 1 commit into from
Jul 16, 2015

Conversation

@phansys
Copy link
Contributor

@phansys phansys commented Jul 15, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
  • SemVer compliant via branch-alias
  • Updated install docs using composer

@phansys phansys force-pushed the composer_improvements branch from 3e4dde4 to 9ca48b3 Compare July 15, 2015 15:51
@Ocramius
Copy link
Member

Ocramius commented Jul 16, 2015

@phansys can you remove and gitignore the composer.lock please?

@phansys phansys force-pushed the composer_improvements branch from 9ca48b3 to 9d6e406 Compare July 16, 2015 12:55
@phansys
Copy link
Contributor Author

phansys commented Jul 16, 2015

@Ocramius, done.

@Ocramius
Copy link
Member

Ocramius commented Jul 16, 2015

@phansys thanks! Sorry, but I have to ask you also for a rebase :-(

@Ocramius Ocramius self-assigned this Jul 16, 2015
@phansys
[Install] Some updates
722b9bc 
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

* SemVer compliant via ```branch-alias```
* Updated install docs using composer
@phansys phansys force-pushed the composer_improvements branch from 9d6e406 to 722b9bc Compare July 16, 2015 19:55
@phansys
Copy link
Contributor Author

phansys commented Jul 16, 2015

No problem at all @Ocramius, rebased ;)

Ocramius added a commit that referenced this pull request Jul 16, 2015
@Ocramius
Merge pull request #4 from phansys/composer_improvements
fe7696b 
[Install] Some updates
@Ocramius Ocramius merged commit fe7696b into doctrine:master Jul 16, 2015
@Ocramius
Copy link
Member

Ocramius commented Jul 16, 2015

👍

@phansys
Copy link
Contributor Author

phansys commented Jul 16, 2015

Thank you @Ocramius!

@phansys phansys deleted the composer_improvements branch July 16, 2015 19:59
gianarb
gianarb reviewed Aug 21, 2015
View reviewed changes
composer.json
Copy link

@gianarb gianarb Aug 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry but why ~1.0?! Now php_codesniffer has 2.0 release

Copy link

@TomasVotruba TomasVotruba Aug 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gianarb It was just copied from line bellow: https://github.com/doctrine/coding-standard/pull/4/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780L16

For bumping to PHP_CodeSniffer 2.0 I'd recommend standalone PR. There are many BC breaks.

Copy link

@gianarb gianarb Aug 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I noticed this change because in doctrine/DoctrineModule composer was broken :)

Copy link

@TomasVotruba TomasVotruba Aug 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gianarb You mean this PR has broken something? Could you send link?

Copy link

@gianarb gianarb Aug 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctrine/DoctrineModule@4b62a2c

Copy link

@TomasVotruba TomasVotruba Aug 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gianarb I see, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

Improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phansys @Ocramius @TomasVotruba @gianarb