Moved the check on mapped superclasses to an dedicated method#162
Merged
beberlei merged 3 commits intodoctrine:masterfrom Jul 7, 2012
Merged
Moved the check on mapped superclasses to an dedicated method#162beberlei merged 3 commits intodoctrine:masterfrom
beberlei merged 3 commits intodoctrine:masterfrom
Conversation
The previous logic was specific to the ORM and could not be reused for the MongoDB ODM.
stof
added a commit
to stof/orm
that referenced
this pull request
Jul 6, 2012
This adds the new method introduced in doctrine/common#162
Member
There was a problem hiding this comment.
this method should have a full or no description :)
stof
added a commit
to stof/phpcr-odm
that referenced
this pull request
Jul 6, 2012
This adds the new method introduced in doctrine/common#162
Member
Author
|
Fixed. I also simplified the mock object as the logic was not needed (and would always have returned true anyway in the test where it is used) |
Member
Author
|
@beberlei are you already using this class in the CouchDB ODM or no ? If yes, I can provide you a PR with the update if you want |
beberlei
added a commit
that referenced
this pull request
Jul 7, 2012
Moved the check on mapped superclasses to an dedicated method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic was specific to the ORM and could not be reused for
the MongoDB ODM.
The PR for the ORM is coming.
@lsmith77 the PHPCR ODM will need to be updated as it uses the class from Common too IIRC.