Adding a lost parameter in ObjectRepository#741
Closed
andrewprofile wants to merge 1 commit intodoctrine:masterfrom
Closed
Adding a lost parameter in ObjectRepository#741andrewprofile wants to merge 1 commit intodoctrine:masterfrom
andrewprofile wants to merge 1 commit intodoctrine:masterfrom
Conversation
Member
|
This can't be implemented, as it is a BC break in the interface, sorry... |
Author
|
Yes, You are right it will BC break for Doctrine 2.1.x - 2.2. I'm sorry, I did not check it before. |
Member
|
No, it breaks BC for anyone implementing the interface today, noit only old ORM versions (the ORM is not the only implementer) |
Author
|
Ok, I understand, thanks. Sorry for the mistake. Earlier I thought it was a good idea but you are right, it was a mistake. |
Member
|
@andrewprofile we have our hands tied on basically anything that involves changing interfaces, sorry :-\ |
Author
|
Ok, Thanks for your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the documentation EntityRepository I noticed there findOneBy method has two parameters. But when I tried to use it with the second parameter, my IDE PhpStorm reported the mistake that this method has only one parameter. This is due to the fact that it implements interface ObjectRepository without this parameter. Therefore, I decided to add this parameter for better code completion.
Ps. Sorry for my bad english