Fix __call exception when no metadata has been set #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
May 2, 2017
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
This patch requires test changes.
Member
Author
|
What test changes? You mean writing new test? |
Member
|
Yup. As much as I'm sorry for no tests existing so far, new changes require
to be validated by tests.
…On 2 May 2017 10:10, "Gabriel Ostrolucký" ***@***.***> wrote:
What test changes? You mean writing new test?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#792 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJakEcJH47wY8ddVD_vZDSrAnu-lxvYks5r1uThgaJpZM4NMrfM>
.
|
This makes sure $cm is set before trying to call it in catch block closes #139
Member
Author
|
test added |
Member
|
Thanks @ostrolucky! |
Member
|
Backported via 407abe1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure $cm is set before trying to call it in throw block
closes #139