Fixed logic error in Sharding component#377
Merged
beberlei merged 2 commits intodoctrine:masterfrom Sep 26, 2013
Merged
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-613 We use Jira to track the state of pull requests and the versions they got |
Member
|
@vlastv what's the failing case? Do you have a test to back the change? |
Contributor
Author
|
@Ocramius I added test for this changes. I probably misunderstood your request, and issued false test. In this case, I have not much experience. |
beberlei
added a commit
that referenced
this pull request
Sep 26, 2013
Fixed logic error in Sharding component
This was referenced Dec 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to choose shard by chooser, as is pass the identifiers shard.