Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed logic error in Sharding component #377

Merged
merged 2 commits into from Sep 26, 2013

Conversation

Projects
None yet
4 participants
Contributor

vlastv commented Sep 24, 2013

No need to choose shard by chooser, as is pass the identifiers shard.

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-613

We use Jira to track the state of pull requests and the versions they got
included in.

Owner

Ocramius commented Sep 24, 2013

@vlastv what's the failing case? Do you have a test to back the change?

Contributor

vlastv commented Sep 24, 2013

@Ocramius I added test for this changes.

I probably misunderstood your request, and issued false test. In this case, I have not much experience.

beberlei added a commit that referenced this pull request Sep 26, 2013

Merge pull request #377 from vlastv/patch-1
Fixed logic error in Sharding component

@beberlei beberlei merged commit e0ffc8a into doctrine:master Sep 26, 2013

1 check passed

default The Travis CI build passed
Details

@vlastv vlastv deleted the vlastv:patch-1 branch Sep 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment