Skip to content

Implementation for 'IsNot'-Comparison#675

Closed
pmattmann wants to merge 4 commits intodoctrine:masterfrom
pmattmann:master
Closed

Implementation for 'IsNot'-Comparison#675
pmattmann wants to merge 4 commits intodoctrine:masterfrom
pmattmann:master

Conversation

@pmattmann
Copy link

See PR (doctrine/collections#11)

This is the required implementation for 'IsNotNull'-Filters in Collection-Filtering.

See PR (doctrine/collections#11)

This is the required implementation for 'IsNotNull'-Filters in Collection-Filtering.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the EOL chars you're committing to the repository

See PR (doctrine/collections#11)

This is the required implementation for 'IsNotNull'-Filters in Collection-Filtering.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to IS_NOT.

Pirmin Mattmann added 2 commits May 22, 2013 22:30
…master2

Conflicts:
	lib/Doctrine/ORM/Persisters/BasicEntityPersister.php
	tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php
@asm89
Copy link
Member

asm89 commented May 26, 2013

@pmattmann Actually the Comparison::IS is wrong and should not be there. We deprecated this now. Instead you can now just use ->neq('field', null);.

See e5de0da.

:)

@beberlei
Copy link
Member

Closing as of @asm89 arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants