test updates#13
Merged
jashkenas merged 3 commits intodocumentcloud:masterfrom Jul 29, 2011
Merged
Conversation
…e `which java` test on windows
…ons now (where `where` is available)
Member
|
Thanks for being so conscientious about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey @jashkenas,
while commenting #12 I totally forgot that I've had some local test related changes - I remember having some issues with running rake on 1.9.2 previously.
besides I had a test doing
whichdisabled on windows as it will obviously fail with an error.I rebased and re-added the commit :
kares@3e29a3a
next I refactored the disabled test to work on (newer) windows versions :
kares@663c7e7
and at last I did found a (new) failing test from #11 on 1.8.7 (due to Hash order) and fixed that one as well :
kares@03b5721
now my previous statement about all test passing on 1.8.7, 1.9.2 and jruby 1.6 holds on master (re-tested including 1.8.7 on windows).
sorry about the confusion if I caused any :)