Add speed test diagnostics to reports#282
Merged
Sway-Chan merged 1 commit intoJul 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SpeedTestService.serverId, node placeholder, outbound tag, and reason.Why
When users report speed-test timeouts while nodes still work, the previous diagnostic report could show only aggregate failure reasons. It did not include the temporary speed-test config, per-node failures, or endpoint target DNS evidence, so endpoint geo-DNS issues still required guesswork.
Safety / privacy
redactDeepbefore report rendering.collectNodeIdentifiers/redactIdentifierspass.Validation
npx jest src/shared/__tests__/diagnostic-redact.test.ts src/main/services/__tests__/speed-test-progress.test.ts src/main/services/__tests__/speed-test-endpoint-dns.test.ts src/main/services/__tests__/speed-test-warm-ttfb.test.ts src/main/services/__tests__/speed-test-coalesce.test.ts src/main/services/__tests__/speed-test-runner.test.ts src/main/services/__tests__/speed-test-concurrency.test.ts --runInBandnpx tsc -p tsconfig.main.json --noEmitnpx eslint src/main/services/SpeedTestService.ts src/main/services/DiagnosticService.ts src/main/index.ts src/shared/diagnostic-redact.ts src/shared/__tests__/diagnostic-redact.test.ts src/main/services/__tests__/speed-test-progress.test.ts src/main/services/__tests__/speed-test-endpoint-dns.test.tsReview notes
An independent read-only agent review found issues around speed-test URL query redaction, endpoint DNS probe progress blocking, CONNECT non-200 socket cleanup, query construction errors, and stale docs wording. This branch addresses those findings before publication.