Render properly in Chrome - #5
Merged
Merged
Conversation
Be default the encoding of the files is not UTF8 which forces Chrome to read linked scripts and css incorrectly, which in turn means that we get only plain-text web page without any styling. So this makes the scripts usable in chrome as well. (did not test on firefox)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency on ActiveX seemed odd. Looking inside of the code base I did not see any ActiveX dependencies but the page was still not loading correctly in chrome.
The cause of that is that by default the HTML files are saved in encoding different from UTF8 which makes chrome parse the linked JS and CSS files incorrectly. That in turn causes the page to load without charts (and any css what so ever).
So I fixed that way the files are saved, and also fixed quoting to comply better with HTML, even though both chrome and edge guess correctly what you wanted to do.
You might want to regenerate the example html files to reflect the new encoding. I did not want to do that, because it included my paths and mudded up the purpose of this PR.