Adopt more harness patterns: security-reviewer + ops skills - #24
Merged
Conversation
…ops skills) Pick up four battle-tested patterns from the Epichan production harness, wired into the installed knowledge templates and dogfooded into AgentRig's own harness: - security-reviewer role (P2): optional read-only reviewer on a non-developer model, with Blocking/Warning/Info severity and an APPROVE / REQUEST CHANGES verdict. - no-self-approve skill + pre_merge gate (P9, P10): shared-identity agents must never approve their own PRs; independent approval required. - resolve-conflicts skill (P4, P7): rebase-first conflict repair, verify mergeability. - address-review-comments skill (P4, P5): reply + resolve every thread, verify zero remain. - wiki conventions: optional PR/commit provenance + good-vs-weak entry guidance. Manifest knowledgeVersion -> 0.7.0 so `agentrig update` installs the new artifacts. Docs sources (PRINCIPLES.md, README.md, docs/index.md) updated so the docsite reflects the new roster/skills. Static audit stays 100% / 100%; changeset added. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
doidor
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Picks up four battle-tested patterns from the popular production harnesses (a real ADO/GitHub agent fleet) and wires them into the installed
knowledge/templates, dogfooded into AgentRig's own harness. Output of a read-only verification pass that confirmed all 12 AgentRig principles are validated by popular production harnesses, then implemented the agreed "quick-wins" bundle.What's new
agents/security-reviewer.{yml,md}— read-only, on a non-developer model (gpt-5.5), Blocking/Warning/Info severity + explicit APPROVE / REQUEST CHANGES verdictpre_mergegateskills/no-self-approve/+ state-machine hook — shared-identity agents must never approve their own PRsskills/resolve-conflicts/— rebase-first conflict repair, verify mergeability before pushskills/address-review-comments/— reply + resolve every thread, verify zero remain_TEMPLATE.mdoptional PR/commit provenance +index.mdgood-vs-weak entry guidanceAll skills were adapted forge-neutral (ADO/
az-specifics stripped; GitHubghexamples).Wiring & docs
knowledge/manifest.json: +5 artifacts,knowledgeVersion→ 0.7.0 (soagentrig updateinstalls them).state-machine.yml: optionalsecurity-reviewertransition duringreviewing+no-self-approveinpre_merge.PRINCIPLES.md(Principle 2),README.md,docs/index.md.minor).Verification
eval --static .): 100% (33/33) completeness, 100% (6/6) quality — unchanged from baseline; the 3 new skills carry validdescription+allowed-toolsfrontmatter.agentrig compilepropagated the new skills intoAGENTS.md,CLAUDE.md,.github/copilot-instructions.md.markbook buildsucceeds — docsite builds clean from updated sources.Not included (separate follow-ups)
Bigger items surfaced by the investigation, intentionally out of scope here: Principle 13 (out-of-band flywheels), forge abstraction (ADO/GitHub seam), and the environment-bootstrap pack.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com